----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71670/#review218388 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java Lines 43 (patched) <https://reviews.apache.org/r/71670/#comment306098> Since these are added to every request, it may make sense to create a _static final map_ and cycle through all the headers. Refactor: Extract inline data. If there are additional headers that are context dependent that are added/removed, consider builder implementation. - Ashutosh Mestry On Oct. 24, 2019, 7:25 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71670/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2019, 7:25 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3490 > https://issues.apache.org/jira/browse/ATLAS-3490 > > > Repository: atlas > > > Description > ------- > > Added headers in atlas api by using AtlasHeaderFilter > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java > PRE-CREATION > webapp/src/main/webapp/WEB-INF/web.xml 8f3f175 > > > Diff: https://reviews.apache.org/r/71670/diff/1/ > > > Testing > ------- > > Tested headers for following apis > > > GET: atlas/api/atlas/admin/metrics > GET: atlas/api/atlas/admin/status > > > Thanks, > > Mandar Ambawane > >
