-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71710/
-----------------------------------------------------------
(Updated Nov. 5, 2019, 9:40 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Madhan
Neethiraj, and Sarath Subramanian.
Changes
-------
Pre-commit job succeed.
Bugs: ATLAS-3497
https://issues.apache.org/jira/browse/ATLAS-3497
Repository: atlas
Description
-------
https://issues.apache.org/jira/browse/ATLAS-3483 added adding/removing labels,
it would be good to add audit entry for these operations: classification added
/ classification deleted.
Diffs
-----
client/client-v1/src/main/java/org/apache/atlas/EntityAuditEvent.java
fcd6a62b2
dashboardv2/public/js/utils/Enums.js c7316d542
dashboardv3/public/js/utils/Enums.js c7316d542
intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java
106c7978d
intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java
649f11f71
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
20624da54
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
1f0cc8626
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
173165a28
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
c910d9eeb
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
2c2fc59b9
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
aba988d25
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
b2211fcaa
Diff: https://reviews.apache.org/r/71710/diff/7/
Testing (updated)
-------
- Manual testing on cluster.
1. labels "fordelete" "frompostman" are added by REST call - /addLabels PUT
via Postman. screenshot1.
audits are as expected. see pic2.
2. delete label "fordelete" by REST call - /removeLabels DELETE via Postman.
audits are as expected. see pic2.
- Pre-commit job succeed.
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1527/
File Attachments
----------------
Screen Shot 2019-11-01 at 1.38.22 PM.png
https://reviews.apache.org/media/uploaded/files/2019/11/01/a38995b5-5bf9-4e2a-a7f0-884409c312cf__Screen_Shot_2019-11-01_at_1.38.22_PM.png
Screen Shot 2019-11-01 at 1.39.37 PM.png
https://reviews.apache.org/media/uploaded/files/2019/11/01/987ae5aa-39f6-4d61-87f9-87d2d4439dac__Screen_Shot_2019-11-01_at_1.39.37_PM.png
Thanks,
Le Ma
