> On Jan. 8, 2020, 11:25 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java > > Lines 303 (patched) > > <https://reviews.apache.org/r/71969/diff/2/?file=2199349#file2199349line303> > > > > 'typeDefStore' is class variable. not needed to be passed in method > > params. please review.
All of the methods in AtlasStructDefStoreV2 take in the typeDefStore as a parameter. Hence passing this. - Aadarsh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71969/#review219184 ----------------------------------------------------------- On Jan. 8, 2020, 1:23 a.m., Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71969/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2020, 1:23 a.m.) > > > Review request for atlas, Ashutosh Mestry, Sridhar K, Le Ma, Madhan > Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3486: introduce Namespace typedef > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > 3ebd70d981a734035416fdf9d880cebd68fe2f30 > intg/src/main/java/org/apache/atlas/model/TypeCategory.java > f06f64f450f407e3f9a0e742726ff4dd12ccc695 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > bb7ead0f9f8bab3094eb82e9e286dd58e8a6e3de > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java > 3634fdfd313639eb97b3c4698e091487b0e44a80 > intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java > 4ee68a936f99bb4c819b5335da2cc8bf7d539397 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > 4742d1c0ea7d7a24fee0453d6fe052579ba6bbd2 > intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > 3475ce6aa8dd4cad4caf08ab5501fc8dc37c1339 > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java > b071dc9d664cee9e1ffc54726ffbf15f4f602d30 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java > 0883d54f490e22c6510e6fc0cb804b87713a7ecb > intg/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java > dba2d88146eff314191ae6bb24ad7337b0ea10ae > intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java > 02613b5f7250b14324ed294c22de079b74d55b08 > > intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 7c551304b2b65b90302f6e5fa9fc5b9f1b8e2c12 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > 6016723d82abd47fa15c5f3a94b70c3ce0673413 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java > 5bad615cd5c223b8246d8443ee5b33925a8b22e9 > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > 08b00e76a5a96aa898f4fc252d3abc22845be50b > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > b04f188beff345d417141d194f0a61e584352111 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java > a5ccfb5b2055c88f596312f4033bc0034d3d165c > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java > 6cd0ee331b7ae24757b58e76ec47bf556106846a > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java > fb56fad6412079e20dd3e345b81a08d9e5ace657 > > > Diff: https://reviews.apache.org/r/71969/diff/2/ > > > Testing > ------- > > As suggested by Madhan in this review here > https://reviews.apache.org/r/71898/, it makes sense to have AtlasNamespaceDef > inherit from AtlasStructDef. This change builds on top of that > > > Thanks, > > Aadarsh Jajodia > >
