----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72025/#review219326 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java Lines 525 (patched) <https://reviews.apache.org/r/72025/#comment307477> when 'attrValue' doesn't contain CUSTOM_ATTR_SEPARATOR (i.e. '='), this method returns null. I suggest to return 'attrValue' in such case. This could be used to search user-defined properties for 'attrValue' in any property name or value. Please review. if (key != null && value != null) { ret = String.format(CUSTOM_ATTR_SEARCH_FORMAT, key, value); } else { ret = attrValue; } - Madhan Neethiraj On Jan. 17, 2020, 9:04 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72025/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2020, 9:04 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, > mayank jain, Nixon Rodrigues, and Sidharth Mishra. > > > Bugs: ATLAS-3591 > https://issues.apache.org/jira/browse/ATLAS-3591 > > > Repository: atlas > > > Description > ------- > > User-defined properties search is enabled in system attribute search. This > Jira is improve the usability of the user-defined properties search. > > For. e.g > > "entityFilters": { "condition": "AND", "criterion": [ { "attributeName": > "__customAttributes", "operator": "contains", "attributeValue": "key2=value2" > } ] } > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 278b97faa > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java > b2c1d4aa5 > > > Diff: https://reviews.apache.org/r/72025/diff/1/ > > > Testing > ------- > > Updated unit tests to test this improvement. > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1609/console > > > Thanks, > > Sarath Subramanian > >
