----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72046/#review219415 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Lines 930 (patched) <https://reviews.apache.org/r/72046/#comment307592> Are namespace attributes saved as a stringfied value in vertex (with property-name NAMESPACE_ATTRIBUTES_PROPERTY_KEY)? Instead, each namespace attribute should be saved in a separate vertex-property - just like attributes of entities/classifications/structs/relationships. This is important to support search by namespace attributes. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Lines 773 (patched) <https://reviews.apache.org/r/72046/#comment307595> Instead of iterating through all vertex attributes, consider the following approach: AtlasEntityType entityType = typeRegistry.getEntityType(entity.getTypeName()); Map<String, List<AtlasNamespaceAttribute>> entityNamespaces = entityType.getNamespaceAttributes(); if (MapUtils.isNotEmpty(entityNamespaces)) { for (Map.Entry<String, List<AtlasNamespaceAttribute>> nsEntry : entityNamespaces.entrySet()) { String nsName = nsEntry.getKey(); List<AtlasNamespaceAttribute> nsAttributes = nsEntry.getValue(); for (AtlasNamespaceAttribute nsAttribute : nsAttributes) { Object attrValue = mapVertexToAttribute(entityVertex, nsAttribute, null, false, false); entity.setNamespaceAttribute(nsName, nsAttribute.getName(), attrValue); } } } Also update EntityGraphMapper to use above approach (of using entityType.getNamespaceAttributes() and AtlasNamespaceAttribute) to save/update/delete namespace attributes in vertex. webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java Lines 858 (patched) <https://reviews.apache.org/r/72046/#comment307593> In addition to these 2 REST APIs, please consider adding following APIs that deal with specific namespace, and specific namespace attribute: PUT /guid/{guid}/namespace/{namespace} body: Map<String, Object> DELETE /guid/{guid}/namespace/{namespace} GET /guid/{guid}/namespace/{namespace} return: Map<String, Object> PUT /guid/{guid}/namespace/{namespace}/{attrName} body: attribute-value DELETE /guid/{guid}/namespace/{namespace}/{attrName} GET /guid/{guid}/namespace/{namespace}/{attrName} return: Object - Madhan Neethiraj On Jan. 28, 2020, 10:44 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72046/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2020, 10:44 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3534 > https://issues.apache.org/jira/browse/ATLAS-3534 > > > Repository: atlas > > > Description > ------- > > Created separate endpoints to associate Namespace attributes to entity > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 0b28243 > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2054513 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 1b033b9 > intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java a141d4a > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 5ab9f4d > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 928c70d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 25284e9 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > e427a59 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > dc4c399 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6845121 > > > Diff: https://reviews.apache.org/r/72046/diff/5/ > > > Testing > ------- > > Basic testing is done. > > Create NamespaceDef sports: > > curl --location --request POST > 'http://localhost:21000/api/atlas/v2/types/typedefs' \ > --header 'Content-Type: application/json' \ > --header 'Authorization: Basic YWRtaW46YWRtaW4=' \ > --data-raw '{ > "namespaceDefs": [ > { > "name": "sports", > "description": "Sample sports", > "serviceType": "NAMESPACES", > "typeVersion": "1.0", > "attributeDefs": [ > { > "name": "sports_name", > "typeName": "string", > "options": { > "applicableEntityTypes": "[\"hdfs_path\", > \"hive_table\"]", > "maxStrLength": "50" > }, > "cardinality": "SINGLE", > "isIndexable": true, > "isOptional": true, > "includeInNotification": true, > "isUnique": false > }, > { > "name": "no_of_players", > "typeName": "int", > "options": { > "applicableEntityTypes": "[\"hdfs_path\", > \"hive_column\"]" > }, > "cardinality": "SINGLE", > "isIndexable": true, > "isOptional": true, > "includeInNotification": true, > "isUnique": false > } > ] > } > ] > }' > > > Create NamespaceDef vehicle: > > curl --location --request POST > 'http://localhost:21000/api/atlas/v2/types/typedefs' \ > --header 'Content-Type: application/json' \ > --header 'Authorization: Basic YWRtaW46YWRtaW4=' \ > --data-raw '{ > "namespaceDefs": [ > { > "name": "vehicle", > "description": "Sample vehicle", > "serviceType": "NAMESPACES", > "typeVersion": "1.0", > "attributeDefs": [ > { > "name": "vehicle_name", > "typeName": "string", > "options": { > "applicableEntityTypes": "[\"hdfs_path\", > \"hive_table\"]", > "maxStrLength": "50" > }, > "cardinality": "SINGLE", > "isIndexable": true, > "isOptional": true, > "includeInNotification": true, > "isUnique": false > }, > { > "name": "no_of_wheels", > "typeName": "int", > "options": { > "applicableEntityTypes": "[\"hdfs_path\", > \"hive_column\"]" > }, > "cardinality": "SINGLE", > "isIndexable": true, > "isOptional": true, > "includeInNotification": true, > "isUnique": false > } > ] > } > ] > }' > > > Create hdfs_path entity: > > curl --location --request POST 'http://localhost:21000/api/atlas/v2/entity' \ > --header 'Content-Type: application/json' \ > --header 'Authorization: Basic YWRtaW46YWRtaW4=' \ > --data-raw '{ > "entity": { > "guid": "-1", > "typeName": "hdfs_path", > "attributes": { > "clusterName": "cm", > "description": "desc", > "location": "localhost", > "name": "hdfs_path_entity1", > "owner": "admin", > "ownerType": "USER", > "qualifiedName": "hdfs_path_entity1@cm", > "path": "local_path" > } > } > }' > > > Associate namespace attributes with the created entity > > > curl --location --request POST > 'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces' > \ > --header 'Content-Type: application/json' \ > --header 'Authorization: Basic YWRtaW46YWRtaW4=' \ > --data-raw '{ > "sports":{ > "sports_name":"cricket", > "no_of_players":11 > }, > "vehicle":{ > "vehicle_name": "Car" > } > }' > > > Add one more namespace attribute in the entity > > curl --location --request POST > 'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces' > \ > --header 'Content-Type: application/json' \ > --header 'Authorization: Basic YWRtaW46YWRtaW4=' \ > --data-raw '{ > "vehicle":{ > "no_of_wheels": 4 > } > }' > > > Update sports_name attribute with new value as Hockey > > curl --location --request POST > 'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces' > \ > --header 'Content-Type: application/json' \ > --header 'Authorization: Basic YWRtaW46YWRtaW4=' \ > --data-raw '{ > "sports":{ > "sports_name": "Hockey" > } > }' > > > Delete vehicle.vehicle_name namespace attribute > > curl --location --request DELETE > 'http://localhost:21000/api/atlas/v2/entity/guid/ea633224-ccfe-4573-9060-43190cd9531a/namespaces' > \ > --header 'Content-Type: application/json' \ > --header 'Authorization: Basic YWRtaW46YWRtaW4=' \ > --data-raw '{ > "vehicle":{ > "vehicle_name": "Car" > } > }' > > > Thanks, > > Mandar Ambawane > >
