Can this be reviewed please?

Sent from my iPhone

Begin forwarded message:

> From: Mariusz Górski <gorskimarius...@gmail.com>
> Date: 10 February 2020 at 12:22:51 CET
> To: Bolke de Bruin <bdbr...@gmail.com>
> Cc: atlas <d...@atlas.incubator.apache.org>, Mariusz Górski 
> <gorskimarius...@gmail.com>
> Subject: Review Request 72104: Enable logging to STDOUT in Atlas startup 
> scripts
> Reply-To: Mariusz Górski <gorskimarius...@gmail.com>@reviews.apache.org
> 
> 
> This is an automatically generated e-mail. To reply, visit: 
> https://reviews.apache.org/r/72104/
> 
> Review request for atlas and Bolke de Bruin.
> By Mariusz Górski.
> Repository: atlas
> Description
> 
> This patch enables logging to STDOUT from processes spawned through 
> atlas_start.py or atlas_config.py scripts. For now, even if configured in 
> log4j, logging to STDOUT was supressed (by redirecting to log files only).
> Testing
> 
> The tests were concluded by:
> 
> Building & running Atlas locally with default log4j configuration and 
> ENABLE_LOGGING_TO_CONSOLE variable set to true.
> Building & running Atlas on Openshift with log4j configuration pushing 
> everything to STDOUT and ENABLE_LOGGING_TO_CONSOLE variable set to true.
> 
> In both scenarios logs were available both in the .out/.err files in the 
> Atlas logdir (backwards compatibility), but at the same time I was able to 
> see them in STDOUT of both running process (local installation) and pod 
> (openshift deployment).
> Diffs
> 
> distro/src/bin/atlas_config.py (f09026ff9)
> distro/src/bin/atlas_start.py (963faf402)
> View Diff

Reply via email to