> On March 4, 2020, 7:29 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > > Lines 286 (patched) > > <https://reviews.apache.org/r/72156/diff/2/?file=2212025#file2212025line286> > > > > typeNamePredicate can be null here (see #159 above); please review if > > #286 should be surrounded with: > > if (typeNamePredicate != null)
Thanks Madhan will surely add it - Pinal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72156/#review219751 ----------------------------------------------------------- On Feb. 25, 2020, 7:11 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72156/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2020, 7:11 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3618 > https://issues.apache.org/jira/browse/ATLAS-3618 > > > Repository: atlas > > > Description > ------- > > 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected > 2) Entities of internal types like AtlasGlossary etc appears when > ALL_ENTITY_TYPES is selected > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > c0a5a46dd > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > b5606d046 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > bb1e9f633 > > > Diff: https://reviews.apache.org/r/72156/diff/2/ > > > Testing > ------- > > 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes > guid isnotnull) and no internal types(whoes supertype is not _internal) > 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result > 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no > result > > Usecase: > -> Added, term1 in Glossary > -> added classification1 to term1 > 1) In search Panel(showing all entities) -> term1 shouln't appear > 2) In classification Panel, showing all entities associated to > classification1 -> term1 shouldn't appear > > > Thanks, > > Pinal Shah > >
