----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72188/#review219945 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java Line 121 (original) <https://reviews.apache.org/r/72188/#comment308187> I suggest to retain attributePredicates in inMemoryPredicate. IIRC, they were added to account for excessive results from index/graph queries. - Madhan Neethiraj On March 13, 2020, 11:10 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72188/ > ----------------------------------------------------------- > > (Updated March 13, 2020, 11:10 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3650 > https://issues.apache.org/jira/browse/ATLAS-3650 > > > Repository: atlas > > > Description > ------- > > When Asset typeName, which has many subtypes, with some attribute filter is > searched , > query formed for typeName is not included in final query > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > c9f3166f1 > > > Diff: https://reviews.apache.org/r/72188/diff/2/ > > > Testing > ------- > > 1) Select Asset > 2) Select Guid notNull > --> Before, all entities with guid notnull including internal > Type(AtlasGlossary) where coming in result > --> Now, Entities with typeName Asset and allSubtypes with guid notnull is > coming in result > > > Thanks, > > Pinal Shah > >
