----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72300/#review220241 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java Lines 66 (patched) <https://reviews.apache.org/r/72300/#comment308570> - I suggest to remove businessMetadataNames, as it has the same value as businessMetadata.keys() i.e. avoid duplicate - rename businessMetadata => businessAttributes, just as it is named in AtlasEntity. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Lines 696 (patched) <https://reviews.apache.org/r/72300/#comment308571> This returns all available business attributes in the entity. Instead of including all attribues, only the attributes requested in the search should be returned in AtlasHeader - refer to block below at #720 below that retrieves only requested attributes. In fact the block below at #720 should already handle business attributes as well. Search request should add desired business attributes in 'attributes', in the following format: <business-metadata-name>.<attribute-name> - the same format used to in filter criteria. Please verify that business-attributes are indeeded included in AtlasEntityHeader.attrbutes. If true, changes in this patch shouldn't be necessary. - Madhan Neethiraj On April 1, 2020, 10:43 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72300/ > ----------------------------------------------------------- > > (Updated April 1, 2020, 10:43 a.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, Mandar Ambawane, > Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3696 > https://issues.apache.org/jira/browse/ATLAS-3696 > > > Repository: atlas > > > Description > ------- > > For instance, there is no way to show "Business Metadata" column if Business > Metadata attribute filter is not applied while searching. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > 7d2476a64 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 3a0d001bc > > > Diff: https://reviews.apache.org/r/72300/diff/1/ > > > Testing > ------- > > Selected Entity which has business attribute, the response of basic search > will include businessMetadata attributes > > > Thanks, > > Pinal Shah > >
