----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72411/#review220408 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 21, 2020, 9:45 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72411/ > ----------------------------------------------------------- > > (Updated April 21, 2020, 9:45 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3747 > https://issues.apache.org/jira/browse/ATLAS-3747 > > > Repository: atlas > > > Description > ------- > > ATLAS-3747: Atlas Admin Purge API should take list of guids as query param > instead of body > > > Diffs > ----- > > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java > 5a19a0b0e > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > a7d554a36 > > > Diff: https://reviews.apache.org/r/72411/diff/2/ > > > Testing > ------- > > Manual Testing: > > curl -u admin:admin123 --location --request PUT > 'http://sid-ycloud-atlas2-1.sid-ycloud-atlas2.root.hwx.site:31000/api/atlas/admin/purge/' > \ > --header 'Content-Type: application/json' \ > --header 'Content-Type: application/json' \ > --header 'Cookie: ATLASSESSIONID=node0g7w7rpfe6o0a1e4e7hk5cth4d2.node0' \ > --data-raw '["bd7262f6-fed5-40f3-9f72-f57fba6b1193", > "24c4df6e-b27a-4c60-b85a-67ed20210446", > "24c4df6e-b27a-4c60-b85a-67ed20210446"]' > > Note: As local jetty was failing for couple of times, I was not able to run > EntityV2JerseyResourceIT. precommit run will ensure if this passes. > > > Thanks, > > Sidharth Mishra > >
