> On May 11, 2020, 5:48 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > > Line 578 (original), 584 (patched) > > <https://reviews.apache.org/r/72474/diff/7/?file=2231098#file2231098line584> > > > > Duplicate code.
Kindly refer to last two replies for Sarath's comments :both if and else condition executes the same statement. please review & same here. remove if/else condition - chaitali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72474/#review220706 ----------------------------------------------------------- On May 11, 2020, 5:56 p.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72474/ > ----------------------------------------------------------- > > (Updated May 11, 2020, 5:56 p.m.) > > > Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-3783 > https://issues.apache.org/jira/browse/ATLAS-3783 > > > Repository: atlas > > > Description > ------- > > Unable to get results for Dsl query eg;hive_column where > table.name="employee". > Due to regression only one edge direction was giving results. > This patch gives a fix for results for both relationship edge direction > queries. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > 04b177533 > repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java > 6ab61e16b > repository/src/main/java/org/apache/atlas/query/Lookup.java 3c192d824 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > 2b34abff8 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 0bbff2f46 > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 6f4df88f0 > > > Diff: https://reviews.apache.org/r/72474/diff/8/ > > > Testing > ------- > > TestCases added. > > > Thanks, > > chaitali > >
