> On June 24, 2020, 1:20 a.m., Sarath Subramanian wrote: > > addons/models/3000-Cloud/3050-ozone-typedefs.json > > Lines 15 (patched) > > <https://reviews.apache.org/r/72614/diff/1/?file=2234884#file2234884line15> > > > > "isOptional" is set to false for all attributes of "keyLocations". Can > > there be cases where you don't have all the information and only some.
I am not sure about this, in this case may I keep all attributes of "keyLocations" as "isOptional: true"? - Nikhil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72614/#review221057 ----------------------------------------------------------- On June 24, 2020, 2:07 p.m., Nikhil Bonte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72614/ > ----------------------------------------------------------- > > (Updated June 24, 2020, 2:07 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon > Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3856 > https://issues.apache.org/jira/browse/ATLAS-3856 > > > Repository: atlas > > > Description > ------- > > Add following ozone typeDefs to Atlas models > > entityDefs: > Ozone volume > Ozone bucket > Ozone key > > enumDefs: > ozone_storage_type > ozone_replication_type > > structDefs: > keyLocation > > relationshipDefs: > ozone_volume_buckets > ozone_bucket_keys > > > Diffs > ----- > > addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/72614/diff/2/ > > > Testing > ------- > > > Thanks, > > Nikhil Bonte > >
