----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221273 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 622 (patched) <https://reviews.apache.org/r/72646/#comment310151> getId should be sufficient here. repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Line 649 (original), 662 (patched) <https://reviews.apache.org/r/72646/#comment310152> Consider replacing this with AtlasGraphTraversal. This should be easy change but will give good performance mileage. repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Lines 705 (patched) <https://reviews.apache.org/r/72646/#comment310153> What is the volume of data you have tested this with? - Ashutosh Mestry On July 6, 2020, 9:14 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72646/ > ----------------------------------------------------------- > > (Updated July 6, 2020, 9:14 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3876 > https://issues.apache.org/jira/browse/ATLAS-3876 > > > Repository: atlas > > > Description > ------- > > **Issue:** > Relationship api doesn't provide approximate count of the related entities in > the response. > > **Workaround:** > Get the total count of related given entity , irrespective of the > offset/limit. > > > Also this patch includes **improvement in the time taken to fetch related > entities** . > Average time taken for the Api to search relationship entities having **5000 > end vertices** with limit **500**: > Before : 9seconds > After applying this patch : 3seconds > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 4b9564295 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 863a00350 > repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java > 5069d78c8 > > > Diff: https://reviews.apache.org/r/72646/diff/2/ > > > Testing > ------- > > Manually tested > Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 > (Failed in Impala build) > > > Thanks, > > Pinal Shah > >
