----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221300 -----------------------------------------------------------
atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 18 (patched) <https://reviews.apache.org/r/72698/#comment310177> - move all Java files to to org.apache.atlas.examples package - also, consider moving this to a sub-project named SampleApp, similar to Ranger examples here: https://github.com/apache/ranger/tree/master/ranger-examples atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 31 (patched) <https://reviews.apache.org/r/72698/#comment310178> AtlasClientBaseExample => SampleApp atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 32 (patched) <https://reviews.apache.org/r/72698/#comment310176> CLUSTER_SUFFIX => METADATA_NAMESPACE_SUFFIX atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 55 (patched) <https://reviews.apache.org/r/72698/#comment310184> empSalaryGlossary is used only in GlossaryExample. Consider moving this filed to GlossaryExample. Review other fields for the same. atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java Lines 62 (patched) <https://reviews.apache.org/r/72698/#comment310179> urls => atlasServerUrls - also in #66, #73 atlas-examples/src/main/java/org/apache/atlas/DiscoveryExample.java Lines 28 (patched) <https://reviews.apache.org/r/72698/#comment310183> Classes DiscoveryExample, EntityRestBaseExample, GlossaryExample, LineageExample and TypeDefExample derive from only to share few constants. I suggest to avoid this hierachy. To share constants, consider having all constants in a class like 'SampleAppConstants'. - Madhan Neethiraj On July 21, 2020, 4:24 p.m., Jyoti Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72698/ > ----------------------------------------------------------- > > (Updated July 21, 2020, 4:24 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > Using this project users can get an idea as how to integrate with Atlas using > AtlasCleint. This helps the user to understand the basic rest functionality > of Atlas such as > > - EntityRest > - TypeDefRest > - DiscoveryRest > - LineageRest > - GlossaryRest > > > Diffs > ----- > > atlas-examples/pom.xml PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/AtlasClientBaseExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/DiscoveryExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/EntityRestBaseExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/GlossaryExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/LineageExample.java > PRE-CREATION > atlas-examples/src/main/java/org/apache/atlas/TypeDefExample.java > PRE-CREATION > pom.xml 5e0442ae5 > > > Diff: https://reviews.apache.org/r/72698/diff/2/ > > > Testing > ------- > > > Thanks, > > Jyoti Singh > >
