----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72713/ -----------------------------------------------------------
(Updated Aug. 10, 2020, 3 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3892 https://issues.apache.org/jira/browse/ATLAS-3892 Repository: atlas Description ------- 1.This patch implements the search history feature where from UI we will receive below filters. 2.In backend we have introduced a new operator "TIME_RANGE" where all the below 7 attribute values will have TIME_RANGE operator. 3.There will be a slight change in the JSON where previously we were passing the Attribute value in Search parameters from the UI but for below filters we will not pass any attributeValue except for "custom range" filter we provide attribute value for eg ;"attributeValue":"1593541800000,1595442600000" . New 7 filters : 1.last 7 days. 2.Last month. 3.Last 30 days. 4.Today. 5.Yesterday. 6.Custom Range. 7.This Month. Diffs (updated) ----- common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java fcc4494f2 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java c5e3d6f0b repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java cf158cd99 repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java 7b40c2184 Diff: https://reviews.apache.org/r/72713/diff/9/ Changes: https://reviews.apache.org/r/72713/diff/8-9/ Testing ------- Tested with below json: eg : { "excludeDeletedEntities": true, "includeSubClassifications": true, "includeSubTypes": true, "includeClassificationAttributes": true, "entityFilters": { "condition": "AND", "criterion": [ { "attributeName": "__timestamp", "operator": "TIME_RANGE", "attributeValue": "YESTERDAY" } ] }, "tagFilters": null, "attributes": [ "__timestamp" ], "limit": 25, "offset": 0, "typeName": "hdfs_path", "classification": null, "termName": null } eg: Only For custom range filter we provide attribute value. { "excludeDeletedEntities": true, "includeSubClassifications": true, "includeSubTypes": true, "includeClassificationAttributes": true, "entityFilters": { "condition": "AND", "criterion": [ { "attributeName": "__timestamp", "operator": "TIME_RANGE", "attributeValue": "1595956315473,1595961000000" } ] }, "tagFilters": null, "attributes": [ "__timestamp" ], "limit": 25, "offset": 0, "typeName": "Table", "classification": null, "termName": null } * Added Test cases to check new processDateRange method functionality Thanks, chaitali