----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72960/#review222071 -----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Lines 114 (patched) <https://reviews.apache.org/r/72960/#comment311137> atlasProperties is used only within importTable(). Consider moving #114 (i.e. declaration) inside importTable() method. addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java Line 384 (original), 386 (patched) <https://reviews.apache.org/r/72960/#comment311138> This change ignores the value given in table.getOwner(), which is not correct. Consider the following: String userName = table.getOwner(); if (StringUtils.isEmpty(userName)) { userName = ApplicationProperties.get().getString(HIVE_USERNAME, "hive")) } processInst.setAttribute(ATTRIBUTE_USER_NAME, userName); - Madhan Neethiraj On Oct. 19, 2020, 12:42 p.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72960/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2020, 12:42 p.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3994 > https://issues.apache.org/jira/browse/ATLAS-3994 > > > Repository: atlas > > > Description > ------- > > 06:33:41.409 [main] ERROR org.apache.atlas.hive.bridge.HiveMetaStoreBridge - > Import failed for hive_table tobedeleted__wallet > org.apache.atlas.AtlasServiceException: Metadata service API > org.apache.atlas.AtlasClientV2$API_V2@17f2dd85 failed with status 404 (Not > Found) Response Body ( > > {"errorCode":"ATLAS-404-00-007","errorMessage":"Invalid instance > creation/updation parameters passed : hive_process.userName: mandatory > attribute value missing in type hive_process"} > > ) > > This patch adds the null check for "owner" to fix the bug. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 24e06dc2b > > > Diff: https://reviews.apache.org/r/72960/diff/2/ > > > Testing > ------- > > Tested import hive script for db, tables > > > Thanks, > > chaitali > >
