> On Oct. 21, 2020, 4:31 a.m., Sarath Subramanian wrote: > > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > > Lines 128 (patched) > > <https://reviews.apache.org/r/72908/diff/3/?file=2240561#file2240561line128> > > > > consider moving initialization lines - 128 and 129 to the constructor
These lines cannot be moved to the constructor because at that moment Spring ApplicationContext container is yet to be populated. Hence we get NPE in BeanUtil.java where ApplicationContext is still null. - Mandar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72908/#review222083 ----------------------------------------------------------- On Oct. 21, 2020, 10:56 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72908/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2020, 10:56 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3957 > https://issues.apache.org/jira/browse/ATLAS-3957 > > > Repository: atlas > > > Description > ------- > > By using Audit Framework, capture audit entries for "Server Start" and > "Server In Active mode" (HA) > > These audit entries can be seen under the "Audits" tab of Admin section. > > > Diffs > ----- > > addons/models/0000-Area0/0010-base_model.json 1de9e57 > > addons/models/0000-Area0/patches/006-base_model_add_atlas_operation_attributes.json > a27525e > intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java > 9ed4168 > test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 > webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > 6985291 > webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 > > > Diff: https://reviews.apache.org/r/72908/diff/4/ > > > Testing > ------- > > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console > > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull > > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console > > > Thanks, > > Mandar Ambawane > >
