----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72993/#review222147 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On Oct. 29, 2020, 9:34 a.m., Nikhil Bonte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72993/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2020, 9:34 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon > Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-4008 > https://issues.apache.org/jira/browse/ATLAS-4008 > > > Repository: atlas > > > Description > ------- > > Problem Statement: > > GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called > multiple times in a same request. > > > > Approach: > > Implement a caching mechanism in GraphTransactionInterceptor to cache the > following mappings: > > * vertexID -> guid > * vertexID -> entityStatus > * edgeId -> status > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java > 57e454a8e > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > ca46d0fdb > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 9360dd3c9 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java > ad5fa92bd > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > b9cbef1b0 > > > Diff: https://reviews.apache.org/r/72993/diff/2/ > > > Testing > ------- > > PC build : > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/167/console > - Finished: SUCCESS > > > Thanks, > > Nikhil Bonte > >
