-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72531/
-----------------------------------------------------------

(Updated Nov. 11, 2020, 7:04 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
-------

rebased the patch


Bugs: ATLAS-3551
    https://issues.apache.org/jira/browse/ATLAS-3551


Repository: atlas


Description
-------

When a HbaseColumnFamily was deleted attribute "table" was assigned null due to 
a check in EntityGraphretriever for legacyattribute where if (table)attribute 
Entity status is ACTIVE and relationship status is DELETED then the attribute 
was assigned null.
Hence this patch fix will it.


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 8208d11c2 
  
repository/src/test/java/org/apache/atlas/repository/impexp/DeletedEntityReferenceTest.java
 PRE-CREATION 
  repository/src/test/java/org/apache/atlas/utils/TestLoadModelUtils.java 
f17538673 


Diff: https://reviews.apache.org/r/72531/diff/5/

Changes: https://reviews.apache.org/r/72531/diff/4-5/


Testing
-------

Added testcases.
Basic testing done :

1.Table Entity-DELETED  Relationship-DELETED    Column Entity-DELETED (Column 
entity will contain attribute table)
2.Table Entity-ACTIVE   Relationship-DELETED    Column Entity-ACTIVE  (Column 
entity will Not contain attribute table)
3.Table Entity-DELETED  Relationship-DELETED    Column Entity-DELETED (Column 
entity will contain attribute table)
4.DB-ACTIVE                 RELATIONSHIP-DELETED    TABLE-ACTIVE          
(Table entity will Not contain attribute db)
5.DB-ACTIVE                 RELATIONSHIP-ACTIVE     TABLE-ACTIVE          
(Table entity will contain attribute db)


Thanks,

chaitali

Reply via email to