-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72921/#review222261
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/utils/AtlasConfigurationUtil.java
Lines 1 (patched)
<https://reviews.apache.org/r/72921/#comment311327>

    Consider keeping this part of AtlasConfiguration itself. That will keep 
this concise.


- Ashutosh Mestry


On Dec. 1, 2020, 6:37 p.m., Deep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72921/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2020, 6:37 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3966
>     https://issues.apache.org/jira/browse/ATLAS-3966
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> If a property is defined multiple times with different values in the 
> application configuration file, while loading the proper, the oldest value is 
> read. Technically this is correct behavior. However many times, instead of 
> updating the value of a particular property, its convenient to just append 
> the property again with a new value in the configuration file.
> 
> This ask is specifically for a property called "atlas.metadata.namespace"
> 
> AtlasConfigurationUtil Class has been created with static method 
> getRecentString.
> All the places where atlas.metadata.namespace property is read from 
> configuration is now read through the new Util method.
> Unit test for the new method is also added.
> 
> 
> Diffs
> -----
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
>  f01266445 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  1bdfa4fcb 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
>  a13b029df 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 25ab7cb3c 
>   intg/src/main/java/org/apache/atlas/utils/AtlasConfigurationUtil.java 
> PRE-CREATION 
>   intg/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java 
> a002a7a8a 
>   intg/src/test/resources/test.properties 395537f30 
>   notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 26c2d8fc1 
> 
> 
> Diff: https://reviews.apache.org/r/72921/diff/2/
> 
> 
> Testing
> -------
> 
> Local Build and Testing done. PreCommit Build Test was done.
> 
> 
> Thanks,
> 
> Deep Singh
> 
>

Reply via email to