-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/
-----------------------------------------------------------
(Updated Jan. 12, 2021, 10:53 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj,
Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
addressed - nit: imports
Bugs: ATLAS-4057
https://issues.apache.org/jira/browse/ATLAS-4057
Repository: atlas
Description
-------
Supporting glossary term in advanced search, will allow user to search the
entities which are assigned to particular glossary term.
**WorkAround:**
'hasTerm' keyword is added to support glossary term.
User needs to add fully qualifiedName of glossary term.
**Example queries to search with term:**
hive_table hasTerm "modernTrade@salesGlossary",
hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
**Example queries to search with relationship:**
hive_table where db.name = "sales"
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java
6c48a82f4
repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 700da955f
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
36b514e84
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.g4
15d1bb4cb
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java
142b9cac9
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens
PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4
f1c10600c
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java
6b33edb53
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java
3139d4374
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserListener.java
PRE-CREATION
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java
a1a727c82
repository/src/test/java/org/apache/atlas/BasicTestSetup.java d733c1642
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
1839e76c7
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3bb3b07bf
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java
487cf2778
Diff: https://reviews.apache.org/r/73058/diff/7/
Changes: https://reviews.apache.org/r/73058/diff/6-7/
Testing
-------
Added testcases in DSLQueriesTest.java
Precommit :
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/268/
Thanks,
Pinal Shah
