----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73157/#review222528 -----------------------------------------------------------
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java Line 433 (original), 436 (patched) <https://reviews.apache.org/r/73157/#comment311632> Can you please uncomment this line? - Ashutosh Mestry On Jan. 25, 2021, 9:52 p.m., Deep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73157/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2021, 9:52 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Pinal Shah, and > Sarath Subramanian. > > > Bugs: ATLAS-4110 > https://issues.apache.org/jira/browse/ATLAS-4110 > > > Repository: atlas > > > Description > ------- > > After upgrading Janusgraph to V-0.5.3, behaviour of DSL queries with neq in > where-clause changed. > > /* > Janusgraph 0.5.3 introduced changes to NOT-EQUAL operator > https://github.com/JanusGraph/janusgraph/issues/2205 > Earlier behavior doesn't check if property exists, so all vertices without > this property was also returned in 'neq'. > Now 'neq' checks if property exists and property is not-equal to property > value > */ > > To handle this case I have introduced HAS_NOT_OPERATOR which basically is an > OR operation of HAS_OPERATOR(with neq check) and HAS_NOT_PROPERTY(checks > absence of a property). > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > c7d01cfb1 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > 587a0990e > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > be55c8ea2 > repository/src/test/java/org/apache/atlas/BasicTestSetup.java 4be094053 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 3f4559a47 > > > Diff: https://reviews.apache.org/r/73157/diff/3/ > > > Testing > ------- > > Manual testing was done. > Unit test is added. > > > Thanks, > > Deep Singh > >
