----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73197/#review222626 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 541 (patched) <https://reviews.apache.org/r/73197/#comment311785> vertex is not yet added to deletionCandidates; it is added only in #547 below. Hence #541 can be removed. Please review. - Madhan Neethiraj On Feb. 23, 2021, 9:44 a.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73197/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2021, 9:44 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nikhil Bonte, Nixon Rodrigues, Pinal Shah, and Sarath Subramanian. > > > Bugs: ATLAS-4171 > https://issues.apache.org/jira/browse/ATLAS-4171 > > > Repository: atlas > > > Description > ------- > > We need to implement one of the flag ignoreUnauthorisedGuids, > isSkipFailedEntities, skipFailedEntities similar to Bulk create/update entity > POST API > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > e6fe306e3 > > > Diff: https://reviews.apache.org/r/73197/diff/2/ > > > Testing > ------- > > When skipFailedEntities passed as a flag true only authorised entities get > deleted skipping unauthorised . > > > Thanks, > > chaitali > >
