----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73172/#review222804 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java Lines 398 (patched) <https://reviews.apache.org/r/73172/#comment311986> replace this.typeRegistry.getBusinessMetadataDefByName(typeName); to typeRegistry.getBusinessMetadataDefByName(typeName); Can you please review of 'this' is needed repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java Lines 403 (patched) <https://reviews.apache.org/r/73172/#comment311985> String qualifiedName = AtlasStructType.AtlasAttribute.getQualifiedAttributeName(businessMetadataDef, attributeDef.getName()); String vertexPropertyName = AtlasStructType.AtlasAttribute.generateVertexPropertyName(businessMetadataDef, attributeDef, qualifiedName); Set<String> applicableTypes = AtlasJson.fromJson(attributeDef.getOption(AtlasBusinessMetadataDef.ATTR_OPTION_APPLICABLE_ENTITY_TYPES), Set.class); Can you align like above - Pinal Shah On April 10, 2021, 8:29 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73172/ > ----------------------------------------------------------- > > (Updated April 10, 2021, 8:29 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > Pinal Shah, and Sarath Subramanian. > > > Bugs: ATLAS-4124 > https://issues.apache.org/jira/browse/ATLAS-4124 > > > Repository: atlas > > > Description > ------- > > We can delete the entire BusinessMetadata TypeDef using the curl command. > > But that will affect the entities which already have Business Attributes from > this Deleted Business Metadata. > Those Business Attributes will be removed from the Entity. > > This patch will restrict user from deleting Business Metadata, if Business > Metadata is already associated with an entity. > > This patch adds support for Multi-Valued Attribute NOT NULL search in Basic > Serch. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > 367c5b8 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 80ab6b4 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 275fc78 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java > d0d54af > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java > 96fb3b4 > webapp/src/test/java/org/apache/atlas/web/adapters/TypeDefsRESTTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/73172/diff/7/ > > > Testing > ------- > > Test cases added > > > Thanks, > > Mandar Ambawane > >
