> On April 26, 2021, 5:32 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > > Lines 865 (patched) > > <https://reviews.apache.org/r/73296/diff/4/?file=2249116#file2249116line865> > > > > line 853 saves to edge as a 'list' object and line 865 reads as String > > object. Consider using list object to read to and write from edge: > > > > To write: > > edge.setListProperty(property, list); > > > > To read: > > List list = AtlasGraphUtilsV2.getEncodedProperty(edge, property, > > List.class);
AtlasGraphUtilsV2.getEncodedProperty(edge, property, List.class) throws 'ClassCastException'. Reason for change is the manner in which list property is stored in edge. It is different from vertex. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73296/#review222863 ----------------------------------------------------------- On April 26, 2021, 5:56 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73296/ > ----------------------------------------------------------- > > (Updated April 26, 2021, 5:56 a.m.) > > > Review request for atlas, Jayendra Parab and Sarath Subramanian. > > > Bugs: ATLAS-4256 and ATLAS-4258 > https://issues.apache.org/jira/browse/ATLAS-4256 > https://issues.apache.org/jira/browse/ATLAS-4258 > > > Repository: atlas > > > Description > ------- > > **Background** > Please read bug description. > > **Approach** > New: *TaskFactoryRegistry*: Registration process for individual factory. > Modified: *AdminResource* Removed the postConstruct calling of > *queuePendingTasks*. This is now part of *TaskManagement*, which is better > design. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 20d5e6fab > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > 8d4fdf388 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > d8ef32b32 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagateTaskFactory.java > 6244b2d5d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationPropagationTasks.java > 4fda34aca > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java > 369db087b > repository/src/main/java/org/apache/atlas/tasks/TaskFactoryRegistry.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/tasks/TaskManagement.java > 264aa8cfb > > repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationWithTasksTest.java > e309a7658 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 714b400c8 > > > Diff: https://reviews.apache.org/r/73296/diff/5/ > > > Testing > ------- > > **Functional tests** > Manually simulated failover scenarios. > > Steps: > - Start Atlas on a cluster with multiple instances. > - Start propagation task that takes few minutes to complete. > - Shutdown active instance. > > Expected behavior: Task should be started from the active node. > > > Thanks, > > Ashutosh Mestry > >
