----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73402/#review223096 -----------------------------------------------------------
Ship it! good work! thanks for fixing the flaky tests :) - Sarath Subramanian On June 3, 2021, 7:23 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73402/ > ----------------------------------------------------------- > > (Updated June 3, 2021, 7:23 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4301 > https://issues.apache.org/jira/browse/ATLAS-4301 > > > Repository: atlas > > > Description > ------- > > Getting following error on Pre-commit build due to change in the file path > > hive-bridge/target/logs/application.log > > Wrong FS: > pfile:/home/jenkins/jenkins-agent/workspace/Atlas/PreCommit-ATLAS-Build-Test/addons/hive-bridge/target/partition-data-{dir}, > expected: file:/// > > > Also, > > There is Enum "Type" in the "Entity" > > Class: org.apache.hadoop.hive.ql.hooks.Entity > Enum: Type > Enum "Type" has one constant "LOCAL_DIR" > > Due to recent changes, we need to provide support for this constant > "LOCAL_DIR" in Testing Environment. > > Without which following issues occuring on Testing Environment: > > 1. While creating "hive_process" entity, The "outputs" attribute is not > getting set (Which is of type "hdfs_path"). > > 2. While setting the "qualifiedName" of "hive_process" entity, File path is > not getting appended. > > This causing Failure of some Test cases. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java > 21c0ae3 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java > 7a11ec3 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 52684e7 > > > Diff: https://reviews.apache.org/r/73402/diff/1/ > > > Testing > ------- > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/612/consoleFull > > > Thanks, > > Mandar Ambawane > >
