----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73404/#review223107 -----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java Line 200 (original), 194 (patched) <https://reviews.apache.org/r/73404/#comment312237> This will keep negative guid not only to Path entity types but for all typesToRetain.IdBasedResolver will not be able to find the entities like hive_table with -ve guid which are already created. We need to keep negative guid only for Path entity types. - Radhika Kundam On June 4, 2021, 1:43 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73404/ > ----------------------------------------------------------- > > (Updated June 4, 2021, 1:43 p.m.) > > > Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath > Subramanian. > > > Bugs: ATLAS-4324 > https://issues.apache.org/jira/browse/ATLAS-4324 > > > Repository: atlas > > > Description > ------- > > **Approach** > Updates: > - Simplified approach. > - Maintained abstraction. > - Updated unit tests. > > > Diffs > ----- > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 94ef22577 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java > 737c637bf > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java > 9163c4709 > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java > 4dde1dc2f > addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 881ee105e > > addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json > 42553b5cf > > addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json > a5b810f72 > addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json > 8e55b7282 > addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json > 801918e04 > addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json > dd31aa073 > > addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json > 7f90d1986 > > addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json > dd31aa073 > addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 > addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json > f2b2bf7a8 > > > Diff: https://reviews.apache.org/r/73404/diff/2/ > > > Testing > ------- > > **Unit tests** > - Additional unit test. > > **PC Build** > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/617/ > > > Thanks, > > Ashutosh Mestry > >
