----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73370/#review223139 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java Lines 363 (patched) <https://reviews.apache.org/r/73370/#comment312253> shouldn't new context be passed? return new GremlinQueryComposer(lookup, new Context(lookup), queryMetadata, this.providedLimit, this.providedOffset, null); - Ashutosh Mestry On June 7, 2021, 10:28 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73370/ > ----------------------------------------------------------- > > (Updated June 7, 2021, 10:28 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4300 > https://issues.apache.org/jira/browse/ATLAS-4300 > > > Repository: atlas > > > Description > ------- > > **Problem:** Advanced Search support Searching entities by classification > Ex. Table isA Dimension > > But user cannot search entities by classification attributes > Ex. To search entities which has classification Dimension and Dimension.attr > = value > > **Improvement:** User will be able to search entities through classification > attributes too. > > **Example query:** "From Table where name = 'sales_fact' and Dimension.attr = > 'value' " > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/query/DSLVisitor.java 80250fb96 > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > 320acbe22 > repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java > c53a324a1 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > eb3c349f6 > repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java > 4091fe982 > repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 > 4bdf479f1 > repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java > 04f602c0f > repository/src/test/java/org/apache/atlas/BasicTestSetup.java 99e075ac5 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 0c1dd59d2 > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 3a2d66d8c > > > Diff: https://reviews.apache.org/r/73370/diff/2/ > > > Testing > ------- > > Unit test cases added > > > Thanks, > > Pinal Shah > >
