----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73453/ -----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nikhil Bonte, Pinal Shah, and Sarath Subramanian. Bugs: ATLAS-4353 https://issues.apache.org/jira/browse/ATLAS-4353 Repository: atlas Description ------- In Atlas, when we create a new classification with name of "name", then the result is it will create a classification named "[]" after that if we tried to remove it then it will failed and even we tried with API to remove the "[]" classification, it will responding with invalid name error. In the Graph store classification name is set with property __type.name in vertex and the list of attribute name of classification are set with property *__type.<classificationName>* in same vertex. If classification name is set with name as "name" , then property __type.name = "name" is overridden by classification attributes with property __type.<classificationName> to empty array [ ie *__type.name=[[]]*.] Diffs ----- repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ff7fd150e repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java fae28c440 repository/src/main/java/org/apache/atlas/repository/patches/RenameClassificationAttributeArrayKey.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEnumDefStoreV2.java 5c02105fe repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java e73f084b8 Diff: https://reviews.apache.org/r/73453/diff/1/ Testing ------- Tested create types with name "name" with different category. Also tested java patch in upgrade scenario. https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/744/console Thanks, Nixon Rodrigues