----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73503/#review223325 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Lines 1621 (patched) <https://reviews.apache.org/r/73503/#comment312408> What is the rationale for this? The way I look at it is: - Fetch edges with a label. (from line 1611) - Checked if edges exists (line 1613) - Found edges, get vertex that is not the passed vertex. - Return the vertex. I don't understand why StringUtils.equals is used. I think the outVertexId == entityVertexId should never be used. Reason: entityVertexId can potentially have edges of different labels. - Ashutosh Mestry On Aug. 4, 2021, 2:55 p.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73503/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2021, 2:55 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4386 > https://issues.apache.org/jira/browse/ATLAS-4386 > > > Repository: atlas > > > Description > ------- > > **Problem:** > > Relationship Search is not able to sort when relationship label is passed as > a queryParam instead of attribute. > > **Example:** > > api/atlas/v2/search/relationship?limit=25&offset=0&guid=cca5c29d-307f-4a9b-ac6c-79f41a08a90b&relation=__hive_table.columns&sortBy=name&sortOrder=DESCENDING > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > f2290c672 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > ff7fd150e > > repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java > a9fbd435a > > > Diff: https://reviews.apache.org/r/73503/diff/1/ > > > Testing > ------- > > added test cases > > > Thanks, > > Pinal Shah > >
