----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73669/#review223683 -----------------------------------------------------------
notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java Lines 123 (patched) <https://reviews.apache.org/r/73669/#comment312791> nit: Fix formatting. notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java Lines 33 (patched) <https://reviews.apache.org/r/73669/#comment312787> Change attemptCount to boolean. That way you caller can simply pass true or false. The logic attemptCount != 0 will depend on caller. notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java Lines 42 (patched) <https://reviews.apache.org/r/73669/#comment312788> Refactor promote to private static final field. notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java Lines 74 (patched) <https://reviews.apache.org/r/73669/#comment312789> Change StringUtils.isBlank to StringUtils.isEmpty. notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java Lines 78 (patched) <https://reviews.apache.org/r/73669/#comment312790> Refactor: Promote to private static final String. - Ashutosh Mestry On Oct. 28, 2021, 9:19 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73669/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2021, 9:19 p.m.) > > > Review request for atlas, Ashutosh Mestry, Disha Talreja, Radhika Kundam, and > Sarath Subramanian. > > > Bugs: ATLAS-4462 > https://issues.apache.org/jira/browse/ATLAS-4462 > > > Repository: atlas > > > Description > ------- > > ATLAS-4462: Updated the pom to stop jetty before start, Added daemon flag to > true to stop jetty at end of post integration, Added retry logic for Kafka > start having port bind issue, Fixed Infinite loop for Index Recovery Service > > > Diffs > ----- > > addons/falcon-bridge/pom.xml 9d56fd8d3 > addons/hbase-bridge/pom.xml 151a62a77 > addons/hive-bridge/pom.xml f62140918 > addons/impala-bridge/pom.xml 87650e1da > addons/kafka-bridge/pom.xml 2ac19fd20 > addons/sqoop-bridge/pom.xml 03861df84 > addons/storm-bridge/pom.xml 6bfe15b5b > notification/src/main/java/org/apache/atlas/kafka/EmbeddedKafkaServer.java > 19717fb2b > notification/src/main/java/org/apache/atlas/util/CommandHandlerUtility.java > PRE-CREATION > pom.xml 84630e76b > webapp/pom.xml 443559c8d > > > Diff: https://reviews.apache.org/r/73669/diff/2/ > > > Testing > ------- > > Manually tested the Infinite loop issue at Index Recovery Service, Kafka > retry logic for kafka start. Along with this I ran the local tests which > passed. > > > Thanks, > > Sidharth Mishra > >
