----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73637/#review223697 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/services/MetricsService.java Line 42 (original), 51 (patched) <https://reviews.apache.org/r/73637/#comment312805> Please import only required util classes. repository/src/main/java/org/apache/atlas/services/MetricsService.java Lines 441 (patched) <https://reviews.apache.org/r/73637/#comment312804> Why do we need to map to AtlasMetricsStat as already allMetrics is List of AtlasMetricsStat repository/src/main/java/org/apache/atlas/services/MetricsService.java Lines 442 (patched) <https://reviews.apache.org/r/73637/#comment312802> Instead of getting entire metricstats and then setting metrics to null here you can send minInfo flas true at Line#436 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 471 (patched) <https://reviews.apache.org/r/73637/#comment312806> At multiple places AtlasMetricsStat taking only Metrics as input then AtlasMetricsStat(Metrics) constructor can be implemented instead of passing null for typeNames. webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 495 (patched) <https://reviews.apache.org/r/73637/#comment312807> getAllMetricsStats(minInfo) returns AtlasMetricsStat. Do we need to map again to cast each element. - Radhika Kundam On Oct. 26, 2021, 3:49 p.m., Disha Talreja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73637/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2021, 3:49 p.m.) > > > Review request for atlas, Ashutosh Mestry, Sarath Subramanian, and Sidharth > Mishra. > > > Bugs: ATLAS-4370 > https://issues.apache.org/jira/browse/ATLAS-4370 > > > Repository: atlas > > > Description > ------- > > Rebased patch #73483 (https://reviews.apache.org/r/73483/) against the newest > master branch. > > > Diffs > ----- > > addons/models/0000-Area0/0010-base_model.json 769d8859f > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java b63fab7cf > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 2febff469 > > intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsMapToChart.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/utils/AtlasEntityUtil.java 1e78e2550 > > repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/services/MetricsService.java > ceb252822 > repository/src/test/java/org/apache/atlas/TestModules.java 8dda20825 > repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java > 040592184 > test-tools/src/main/resources/solr/core-template/solrconfig.xml 3341e7199 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 135b94b36 > > > Diff: https://reviews.apache.org/r/73637/diff/4/ > > > Testing > ------- > > 1) Tested locally. > 2) Patched a cluster. > > PC build: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/880/ > > > Thanks, > > Disha Talreja > >
