----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73700/#review223730 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java Lines 1011 (patched) <https://reviews.apache.org/r/73700/#comment312832> extract as static constant - "r:AtlasGlossaryTermAnchor" - Sarath Subramanian On Nov. 9, 2021, 11:23 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73700/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2021, 11:23 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, and > Sarath Subramanian. > > > Bugs: ATLAS-4473 > https://issues.apache.org/jira/browse/ATLAS-4473 > > > Repository: atlas > > > Description > ------- > > While creating GlossaryTerms we need information about Glossary and > GlossaryCategory (if present) > > As per current design, > When every Term is created, respective Glossary and Category objects are > fetched from db and they are populated with unwanted information. > > In case of bulk creation, > Even if multiple Terms have same Glossary and Category associated with them, > every time these objects are fetched from db and they are populated. > > This patch stores the optimum information of Glossaries and Categoies in the > cache against their respective Guids. > This helps in performance improvement of Bulk Term Creation. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 9c8459874 > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java > d92daeea5 > > > Diff: https://reviews.apache.org/r/73700/diff/1/ > > > Testing > ------- > > Earlier, it was taking more than a day to complete the creation process of > the 2222 Terms. > > Now with the Performacne optimization, it is taking 5 to 6 minutes to > complete. > > > Thanks, > > Mandar Ambawane > >
