[jira] [Commented] (ATLAS-2985) Fix delete handlers and relationship store

[Ryan Jendoubi (Jira)]

    [ 
https://issues.apache.org/jira/browse/ATLAS-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464627#comment-17464627
 ] 

Ryan Jendoubi commented on ATLAS-2985:
--------------------------------------

Hi [~sidharthkmishra] 👋🏼 Does ATLAS-3477 also solve for purging 
{*}Relationships{*}?

As of 2.1.0.7.1.7.0-551 (apologies if I’m missing something) it seems to be the 
case that:
 # The /admin/purge endpoint expects guids for {*}Entities{*}, not 
Relationships, so purging deleted Relationships fails. If I try to purge a 
Relationship which is already deleted, I see two consecutive log messages: 
“Purge request ignored for non-existent/active entity with guid 
<my-relationship-guid> (AtlasEntityStoreV2:574)” and “No purge candidate 
entities were found for guids. The reason seems to be that [the purge 
endpoint|https://github.com/apache/atlas/blob/a4ee6c05ad6e8759cf2945024684bfbd1e7af8e1/webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java#L685-L715]
 hands off only to the Entity store, not the Relationship store.
 # Because the soft-deleted Relationships still exist, deleting the 
RelationshipDef fails (reasonably enough) with “Given type 
<my-relationshipdef-name> has references”.

Therefore, can you please confirm my understanding that this bug report is 
_not_ actually resolved by ATLAS-3477?

And that being the case, can you please consider [~grahamwallis]'s patch for 
merging? :)

> Fix delete handlers and relationship store
> ------------------------------------------
>
>                 Key: ATLAS-2985
>                 URL: https://issues.apache.org/jira/browse/ATLAS-2985
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Graham Wallis
>            Assignee: Graham Wallis
>            Priority: Critical
>         Attachments: ATLAS-2985-2018-11-30.patch
>
>
> The problems this fixes are as follows:
>  * following a soft delete, a hard delete is not possible because the entity 
> or relationship will have status DELETED, and prior to this Jira and patch 
> the abstract delete handler skips the delete. 
>  * during a soft delete the modified-time, modified-by and version number 
> attributes on the entity or relationship should be updated, but 
> updateRelationship does not update system attributes - this Jira and patch 
> updates the system attributes that will need to be updated during a delete or 
> other update operations.
>  * also fixes a minor copy-paste debug logging error.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)