----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73855/#review224075 -----------------------------------------------------------
common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java Line 440 (original), 451 (patched) <https://reviews.apache.org/r/73855/#comment313034> Consider using StringUtils.EMPTY common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java Lines 452 (patched) <https://reviews.apache.org/r/73855/#comment313035> ofs -> Extract to private static const field. common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java Lines 453 (patched) <https://reviews.apache.org/r/73855/#comment313036> Consider usind String.format to construct the string. - Ashutosh Mestry On Feb. 18, 2022, 12:20 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73855/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2022, 12:20 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, Sarath > Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-4556 > https://issues.apache.org/jira/browse/ATLAS-4556 > > > Repository: atlas > > > Description > ------- > > When we provide ozone key as a path for an external table in hive, > corresponding Ozone entities of type "Ozone_Volume", "Ozone_Bucket", > "Ozone_Key" etc. get created. > > Currently in Atlas, code supports the above in "o3fs" ozone scheme. > Need to provide improved support in "ofs" scheme, same as that of "o3fs". > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java > cf8f262b9 > common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java > f35e9ae57 > > > Diff: https://reviews.apache.org/r/73855/diff/1/ > > > Testing > ------- > > > Thanks, > > Mandar Ambawane > >