----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73991/#review224474 -----------------------------------------------------------
Ship it! Ship It! - Radhika Kundam On May 18, 2022, 3:41 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73991/ > ----------------------------------------------------------- > > (Updated May 18, 2022, 3:41 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, > Radhika Kundam, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-4605 > https://issues.apache.org/jira/browse/ATLAS-4605 > > > Repository: atlas > > > Description > ------- > > Because of corrupted data, there may be a chance of having AtlasVertex as an > empty, which means AtlasVertex does not have any property present in it. > This can cause NullPointerException while populating System attributes as > well Normal attributes for AtlasEntity object. > To avoid NullPointerException we need to skip such vertices, so that they > cannot be used to populate system attributes and normal attributes. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > fcd8dfe7f > > > Diff: https://reviews.apache.org/r/73991/diff/1/ > > > Testing > ------- > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1098/consoleFull > > Sanity testing is done. > > Test Scenarios covered: > > Hive hook: > Create table, check column and table relationships > Create ctas table, check relationships > Generate shell entities > Check if added tables are generating correct entries after reversing shell > condition. > Update table entities > > Hbase hook: > Create table, check column family and table relationships > Check if added tables are generating correct entries after reversing hook. > Update table entities > > General: > Search for entities in basic and advanced searches > Save favourite searches > Checked for entity-delete and entity-purge scenarios > Applied classifications > Applied terms > Create and apply business metadata > > > Thanks, > > Mandar Ambawane > >
