----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74017/ -----------------------------------------------------------
Review request for atlas, Jayendra Parab, Mandar Ambawane, and Pinal Shah. Bugs: ATLAS-4531 https://issues.apache.org/jira/browse/ATLAS-4531 Repository: atlas Description ------- Whenever we fire a basic search for _ALL_ENTITY_TYPES, the same set of results are always fetched even if you change the offset. For ex: If these are the results when you select page limit as 2 and offset as 0 (there are total 59 results): x1 x2 Then on increasing the offset to 3 you still get the above results x1 and x2. This only occurs for _ALL_ENTITY_TYPES. If you search for specific data types like hive_table and others the behaviour is normal. Diffs ----- repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java f45ccaf24 Diff: https://reviews.apache.org/r/74017/diff/1/ Testing ------- Manual testing is done. Pre-commit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1103/consoleFull 1) Tried all Combinations of Basic search fields. 2) Ran an all_entity_search search and saved it and re ran it again from Favourite search. 3) Checked with different Limit and Offset Combinations. 4) Navigation between different pages of search in UI. 5) Tested wherever basic search was invoked like in Classification,Metrics etc. 6) Tested using different search filters using filters and filter groups. Thanks, Sanket Shelar