----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74061/ -----------------------------------------------------------
(Updated July 26, 2022, 3:56 p.m.) Review request for atlas, Disha Talreja, Radhika Kundam, and Sidharth Mishra. Bugs: ATLAS-4637 https://issues.apache.org/jira/browse/ATLAS-4637 Repository: atlas Description ------- 1. Add new attribute - importLabel - to MetricsStat. It contains the name/identity of the user who is importing MetricsStat file from one machine to another machine. For some Machine A, importLabel is set to "self" for the already existing MetricsStat that collects the metrics info in Machine A, and has not been imported from another machine. 2. Update metricsId to contain both importLabel and collectionTime to continue holding its property of being a unique attribute. 3. Update MetricsService to implement REST APIs in AdminResource to realize api calls of: 1. Post MetricsStat with a specific importLabel obtained from a another machine. 2. Get MetricsStat with a specific importLabel found in some machine with a boolean flag that returns metrics with specific details, or with minimal information. 3. Delete all existing MetricsStats entities in a given machine. 4. Delete all existing MetricsStats entities in a given machine with a specific importLabel. 5. Get all importLabels. 6. Update MetricsService to include helper methods of: 1. Get a persisted metricsStat by importLabel. 2. Get a persisted metricsStat by collectionTime and importLabel. Diffs ----- intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetricsStat.java 5a30cad06a8616184e09bd48fe99975b6750adc8 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 9924b2e4ce2c7b2d44b64657b300e1592b2bd394 repository/src/main/java/org/apache/atlas/repository/ogm/metrics/AtlasMetricsStatDTO.java 6af935ebbb1f3b5e03589d19ea16d51ba675d5db repository/src/main/java/org/apache/atlas/services/MetricsService.java 9ec2cd2cb249b1f881f01261e7ae7e10f0adbe67 webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java d55ada77edd9d006d6ef31720c427e08984097ba Diff: https://reviews.apache.org/r/74061/diff/1/ Testing ------- File Attachments (updated) ---------------- mypatch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/97326e65-43a6-46ec-8d2f-c9aa02617683__mypatch.patch 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/f5d8267a-f2ae-4746-ab14-d798793cae52__0001-MetricsImportExportUI-ApacheMasterBranch.patch 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/2d5eec26-eafa-496f-8164-28651a694fd9__0001-MetricsImportExportUI-ApacheMasterBranch.patch 0001-MetricsImportExportUI-ApacheMasterBranch.patch https://reviews.apache.org/media/uploaded/files/2022/07/26/0eabb428-689a-4d59-bbae-55b76495c131__0001-MetricsImportExportUI-ApacheMasterBranch.patch Thanks, Beakal Lemeneh