-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74095/
-----------------------------------------------------------

Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4611
    https://issues.apache.org/jira/browse/ATLAS-4611


Repository: atlas


Description
-------

1) Business Metadata ( Entity Detail Page)
String attribute value should have text editor.

2) Classification and Business Metadata 

 The "Description" field should have text editor as it has been implemented for 
the Glossary section.


Diffs
-----

  dashboardv2/public/css/scss/override.scss f98c7fcb7 
  dashboardv2/public/css/scss/texteditor.scss 275bdcc3d 
  dashboardv2/public/js/external_lib/trumbowyg/trumbowyg.js 7ef6d172e 
  
dashboardv2/public/js/templates/business_metadata/BusinessMetadataAttributeItemView_tmpl.html
 3d316f688 
  
dashboardv2/public/js/templates/business_metadata/BusinessMetadataDetailLayoutView_tmpl.html
 d8a2b5b87 
  
dashboardv2/public/js/templates/business_metadata/CreateBusinessMetadataLayoutView_tmpl.html
 a78614d15 
  dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 
c8b55f783 
  dashboardv2/public/js/templates/tag/CreateTagLayoutView_tmpl.html 27ea91247 
  dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 
d12785bd8 
  dashboardv2/public/js/utils/CommonViewFunction.js f15b32e1c 
  dashboardv2/public/js/utils/Helper.js 0ba1b6c4e 
  dashboardv2/public/js/utils/Utils.js f3126db75 
  
dashboardv2/public/js/views/business_metadata/BusinessMetadataDetailLayoutView.js
 422808b82 
  
dashboardv2/public/js/views/business_metadata/BusinessMetadataTableLayoutView.js
 6527eeb27 
  
dashboardv2/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
 21bb663ab 
  dashboardv2/public/js/views/entity/EntityBusinessMetaDataItemView.js 
ff285068d 
  dashboardv2/public/js/views/entity/EntityBusinessMetaDataView.js 213e7cc01 
  dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js b070c5509 
  dashboardv2/public/js/views/tag/CreateTagLayoutView.js 476007a2c 
  dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js be33e7c32 
  dashboardv2/public/js/views/tag/TagLayoutView.js f7af026b7 
  dashboardv3/public/css/scss/override.scss fec5f6f02 
  dashboardv3/public/css/scss/texteditor.scss 275bdcc3d 
  dashboardv3/public/js/external_lib/trumbowyg/trumbowyg.js 7ef6d172e 
  
dashboardv3/public/js/templates/business_metadata/BusinessMetadataAttributeItemView_tmpl.html
 3d316f688 
  
dashboardv3/public/js/templates/business_metadata/BusinessMetadataDetailLayoutView_tmpl.html
 2ad5ba5e0 
  
dashboardv3/public/js/templates/business_metadata/CreateBusinessMetadataLayoutView_tmpl.html
 a78614d15 
  dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 
64e603135 
  dashboardv3/public/js/templates/tag/CreateTagLayoutView_tmpl.html 27ea91247 
  dashboardv3/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 
c999fe140 
  dashboardv3/public/js/utils/CommonViewFunction.js 7aacb9887 
  dashboardv3/public/js/utils/Helper.js 164beac57 
  dashboardv3/public/js/utils/Utils.js d4db9f4b9 
  
dashboardv3/public/js/views/business_metadata/BusinessMetadataDetailLayoutView.js
 ee5b84bdf 
  
dashboardv3/public/js/views/business_metadata/BusinessMetadataTableLayoutView.js
 80932ce51 
  
dashboardv3/public/js/views/business_metadata/CreateBusinessMetadataLayoutView.js
 21bb663ab 
  dashboardv3/public/js/views/entity/EntityBusinessMetaDataItemView.js 
913cc0faf 
  dashboardv3/public/js/views/entity/EntityBusinessMetaDataView.js 81db8935e 
  dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 845ace1c9 
  dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 
e31260d40 
  dashboardv3/public/js/views/tag/CreateTagLayoutView.js 476007a2c 
  dashboardv3/public/js/views/tag/TagAttributeDetailLayoutView.js 52ff0431d 


Diff: https://reviews.apache.org/r/74095/diff/1/


Testing
-------

1)Tested manually for all the pages where text-editor has been implemented for 
all the possible scenarios.

2)Did testing against XSS vulnerability.


Thanks,

Farhan Khan

Reply via email to