----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74341/#review225375 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTask.java Lines 76 (patched) <https://reviews.apache.org/r/74341/#comment314016> Please use AtlasConfiguration.SEARCH_MAX_LIMIT repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTask.java Lines 87 (patched) <https://reviews.apache.org/r/74341/#comment314017> Is this check needed? repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTask.java Lines 151 (patched) <https://reviews.apache.org/r/74341/#comment314018> We should use QueryParams.getNormalizedParams() - Pinal Shah On April 12, 2023, 6:21 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74341/ > ----------------------------------------------------------- > > (Updated April 12, 2023, 6:21 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Pinal Shah, > Radhika Kundam, Sheetal Shah, and Sidharth Mishra. > > > Bugs: ATLAS-4733 > https://issues.apache.org/jira/browse/ATLAS-4733 > > > Repository: atlas > > > Description > ------- > > This ticket tracks the Server side changes required for the Search result > download task. > > From server side, each download request is considered as a separate thread > which will run in the background and will generate the csv file according to > the inputs provided. > > The generated files will be stored in the specific location (which is > configurable). > > A scheduler will be run to delete the old files. In this case, the scheduler > interval and file expiry time is also configurable. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 608342433 > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResultDownloadStatus.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java > d94110004 > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 582d97542 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTask.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTaskFactory.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/tasks/TaskManagement.java > 5b4bf71cc > repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java 6f770edb1 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java a6ca04f3c > > > Diff: https://reviews.apache.org/r/74341/diff/6/ > > > Testing > ------- > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1338/consoleFull > > Request to generate csv file with default columns seen on UI: > > curl -u <username>:<password> --request POST > "<host>:<port>/api/atlas/v2/search/basic/download/create_file" --header > 'Content-Type: application/json' --data-raw > '{"searchParameters":{"excludeDeletedEntities":true,"includeSubClassifications":true,"includeSubTypes":true,"includeClassificationAttributes":true,"entityFilters":null,"tagFilters":null,"attributes":[],"limit":25,"offset":0,"typeName":"_ALL_ENTITY_TYPES","classification":null,"termName":null},"attributeLabelMap":{}}' > > > Request to generate csv file with additional columns selected from UI: > > curl -u <username>:<password> --request POST > "<host>:<port>/api/atlas/v2/search/basic/download/create_file" --header > 'Content-Type: application/json' --data-raw > '{"searchParameters":{"excludeDeletedEntities":true,"includeSubClassifications":true,"includeSubTypes":true,"includeClassificationAttributes":true,"entityFilters":null,"tagFilters":null,"attributes":["__guid","__state"],"limit":25,"offset":0,"typeName":"_ALL_ENTITY_TYPES","classification":null,"termName":null},"attributeLabelMap":{"Guid":"__guid","Status":"__state"}}' > > > Thanks, > > Mandar Ambawane > >
