----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74939/ -----------------------------------------------------------
Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah. Repository: atlas Description ------- Create 2 tables create table hive_table_1(id int) stored as iceberg; create table hive_table_2(id int); Export iceberg table using fetchType incremental and changeMarker 0 Import the zip. Expectation is only hive_table_1 to be exported and imported, but it does full export and hive_table_2 is also imported. Diffs ----- repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java da5cf37c4 repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 65d7a1872 Diff: https://reviews.apache.org/r/74939/diff/1/ Testing ------- Steps to repro: create two hive_tables in same database: 1. create table hive1(id int); 2. create table hive2(name string); Expectations: And perform incremental export of hive1 with changeMarker provided by previous export. Import the zip. Expectation is only the requested hive_table hive1 should be exported, but actually hive2 is also imported. Before patch: Export command: -------------- curl -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache" -d '{ "itemsToExport": [ { "typeName": "hive_table", "uniqueAttributes": { "qualifiedName": "test.hive1@cm" } } ], "options": { "fetchType": "INCREMENTAL"} }' "http://ccycloud-2.ppspark37218.root.comops.site:31000/api/atlas/admin/export"; > exportOutput.zip Import command: -------------- curl -g -X POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F data=@exportOutput.zip "http://localhost:21000/api/atlas/admin/import"; After patch: Export command: --------------- curl -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache" -d '{ "itemsToExport": [ { "typeName": "hive_table", "uniqueAttributes": { "qualifiedName": "test.hive1@cm" } } ], "options": { "fetchType": "INCREMENTAL"} }' "http://localhost:21000/api/atlas/admin/export"; > exportOutputAfter.zip Import command: -------------- curl -g -X POST -u admin:admin -H "Content-Type: multipart/form-data" -H "Cache-Control: no-cache" -F data=@exportOutputAfter.zip "http://ccycloud-1.ps7218052.root.comops.site:31000/api/atlas/admin/import"; Thanks, Priyanshi Shah
