----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74939/ -----------------------------------------------------------
(Updated April 4, 2024, 1:16 p.m.) Review request for atlas, Jayendra Parab, Pinal Shah, and Sheetal Shah. Bugs: ATLAS-4842 https://issues.apache.org/jira/browse/ATLAS-4842 Repository: atlas Description ------- Steps: create two hive_tables in same database: 1. create table hive1(id int); 2. create table hive1_ctas as select * from hive1; 3. create table hive2(name string); 4. Perform incremental export of hive1 with changeMarker as 0 and skipLineage value as false. 5. Import the zip. Expectations: a) Expectation is only the requested hive_table hive1 and its related entities should be exported. Problem: hive2 is also imported which is an independently created entity and not related to hive1. Solution: 1. Earlier, the implementation for fetchType as INCREMENTAL was getting satisfied only if the value of skipLineage was "true" otherwise it was implementing the default fetchType i.e FULL fetch and hence, all the independently created entities in same db was also getting fetched. 2. Now, the problem is fixed by adding additional condition which will handle INCREMENTAL fetchType even if the value for skipLineage is false. Diffs (updated) ----- repository/src/main/java/org/apache/atlas/repository/impexp/EntitiesExtractor.java da5cf37c4 repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 65d7a1872 repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java 0e3955dcd repository/src/test/resources/json/stocksDB-Entities/typedef-new-classification-T3.json PRE-CREATION repository/src/test/resources/json/stocksDB-Entities/typesdef-new-classification-T2.json PRE-CREATION Diff: https://reviews.apache.org/r/74939/diff/5/ Changes: https://reviews.apache.org/r/74939/diff/4-5/ Testing ------- Manual testing has been done for the same. PC Link : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1594/ Thanks, Priyanshi Shah