----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74925/#review226393 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java Lines 1083 (patched) <https://reviews.apache.org/r/74925/#comment314604> please another method for #1083 to #1090 private static boolean hasCJKChar(String value, int i) { } repository/src/main/java/org/apache/atlas/discovery/SearchContext.java Lines 120 (patched) <https://reviews.apache.org/r/74925/#comment314606> please move this piece of code above #233 if (needFullTextProcessor()) { repository/src/main/java/org/apache/atlas/discovery/SearchContext.java Lines 121 (patched) <https://reviews.apache.org/r/74925/#comment314607> This will be checked twice, one here and other in EntityDiscoveryService.java public AtlasQuickSearchResult quickSearch(QuickSearchParameters quickSearchParameters) throws AtlasBaseException { String query = quickSearchParameters.getQuery(); if (StringUtils.isNotEmpty(query) && !AtlasStructType.AtlasAttribute.hastokenizeChar(query)) { query = query + "*"; } quickSearchParameters.setQuery(query); please remove from here repository/src/main/java/org/apache/atlas/discovery/SearchContext.java Lines 123 (patched) <https://reviews.apache.org/r/74925/#comment314605> please review the conditions again, for the below cases query = abc@123* should be query = abc@123 query = abc@123 should be query = abc@123 query = abc should be query = abc* query = abc* should be query = abc* if (StringUtils.isNotEmpty(query) && query.endsWith("*")) { query = query.substring(0, query.length()-1); } if (StringUtils.isNotEmpty(query) && !AtlasStructType.AtlasAttribute.hastokenizeChar(query)) { query = query + "*"; searchParameters.setQuery(query); } - Pinal Shah On April 23, 2024, 8:04 a.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74925/ > ----------------------------------------------------------- > > (Updated April 23, 2024, 8:04 a.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Pinal > Shah, and Sheetal Shah. > > > Bugs: ATLAS-4225 > https://issues.apache.org/jira/browse/ATLAS-4225 > > > Repository: atlas > > > Description > ------- > > Updated latest patch with synchronized code > > Creating this review request to track and close > https://reviews.apache.org/r/73256/diff/3#1 as the patch here is not in sync > with latest code > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 591b31612 > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 9a9a5512a > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 01b88eb2f > repository/src/test/java/org/apache/atlas/BasicTestSetup.java 593f8c19b > > repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java > 282a3fd4a > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > 1489b2760 > > > Diff: https://reviews.apache.org/r/74925/diff/3/ > > > Testing > ------- > > Testcases are added in the patch > PC is successful : > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1561/consoleFull > > > Thanks, > > chaitali > >
