----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74996/#review226466 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java Line 107 (original) <https://reviews.apache.org/r/74996/#comment314669> retain blank line repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java Line 114 (original) <https://reviews.apache.org/r/74996/#comment314668> retain blank line repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java Lines 121 (patched) <https://reviews.apache.org/r/74996/#comment314667> add some more data and use those for different test cases - Pinal Shah On May 17, 2024, 11:24 a.m., Darshil shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74996/ > ----------------------------------------------------------- > > (Updated May 17, 2024, 11:24 a.m.) > > > Review request for atlas and Pinal Shah. > > > Bugs: ATLAS-4864 > https://issues.apache.org/jira/browse/ATLAS-4864 > > > Repository: atlas > > > Description > ------- > > Problem: > > When we perform a basic search, using a term with a query filter, it does not > produce the correct output. For example, if we use the filter Term as Term1 > and the query as Joe, the resulting output will be inaccurate. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 9a9a5512a > > repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java > b8a507eac > > repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java > fb94aaedc > > > Diff: https://reviews.apache.org/r/74996/diff/2/ > > > Testing > ------- > > Test cases have been added, and manual testing has been completed. > In the test case, we can filter using term0 and provide felt as the query, > which corresponds to the owner in the entity. This should give us the desired > output. > > > File Attachments > ---------------- > > ATLAS-4864.patch > > https://reviews.apache.org/media/uploaded/files/2024/05/17/b9b0b781-28eb-4d18-9cc0-8d01aa35cf3f__ATLAS-4864.patch > ATLAS-4864.patch > > https://reviews.apache.org/media/uploaded/files/2024/05/17/962f256b-bd3a-44eb-b154-c67dd6cd5c6c__ATLAS-4864.patch > > > Thanks, > > Darshil shah > >
