> On June 18, 2024, 8:04 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
> > Line 41 (original), 41 (patched)
> > <https://reviews.apache.org/r/75054/diff/1/?file=2289122#file2289122line41>
> >
> > Is removing ".has('__guid')" not needed in line #41, #42, #45?
Above queries are used in VertexExtractor and below is the condition of
extractor strategy
return (atlasEntityDef == null ||
atlasEntityDef.getRelationshipAttributeDefs().size() == 0)
? extractors.get(VERTEX_BASED_EXTRACT)
: extractors.get(RELATION_BASED_EXTRACT);
I was not able to verify it, since couldn't get the usecase of the
vertexExtractor Strategy
- Pinal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75054/#review226559
-----------------------------------------------------------
On June 18, 2024, 7:54 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75054/
> -----------------------------------------------------------
>
> (Updated June 18, 2024, 7:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj,
> and Radhika PC.
>
>
> Bugs: ATLAS-4882
> https://issues.apache.org/jira/browse/ATLAS-4882
>
>
> Repository: atlas
>
>
> Description
> -------
>
> please check the jira description
> https://issues.apache.org/jira/browse/ATLAS-4882
>
>
> Diffs
> -----
>
>
> repository/src/main/java/org/apache/atlas/repository/impexp/StartEntityFetchByExportRequest.java
> d01d6775a
>
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
> 5b10c353e
>
>
> Diff: https://reviews.apache.org/r/75054/diff/1/
>
>
> Testing
> -------
>
> Manually verified
>
>
> Thanks,
>
> Pinal Shah
>
>
