----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75270/#review227056 -----------------------------------------------------------
Ship it! Ship It! - Radhika Kundam On Nov. 13, 2024, 8:57 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75270/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2024, 8:57 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Pinal Shah, > Radhika Kundam, and Sarath Subramanian. > > > Bugs: ATLAS-4917 > https://issues.apache.org/jira/browse/ATLAS-4917 > > > Repository: atlas > > > Description > ------- > > - replaced use of log4j with logback > - updated FailedMessageLogger to use logger named > org.apache.atlas.hook.FailedMessagesLogger, instead of writing to file > atlas_hook_failed_messages.log in logs directory > > > Diffs > ----- > > addons/couchbase-bridge/src/test/resources/log4j.xml e53c232d0 > addons/falcon-bridge/pom.xml 3576173b9 > addons/falcon-bridge/src/test/resources/atlas-log4j.xml 262a710f7 > addons/falcon-bridge/src/test/resources/atlas-logback.xml PRE-CREATION > addons/hbase-bridge/pom.xml 278b6c6d3 > addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml > 3fc2dcf9c > addons/hbase-bridge/src/main/resources/atlas-hbase-import-logback.xml > PRE-CREATION > addons/hbase-bridge/src/test/resources/atlas-log4j.xml 2c9815ff5 > addons/hbase-bridge/src/test/resources/atlas-logback.xml PRE-CREATION > addons/hbase-testing-util/src/test/resources/atlas-log4j.xml 47d4d5c7c > addons/hbase-testing-util/src/test/resources/atlas-logback.xml PRE-CREATION > addons/hive-bridge/pom.xml 356ac9542 > addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml 22a8cc9d4 > addons/hive-bridge/src/main/resources/atlas-hive-import-logback.xml > PRE-CREATION > addons/hive-bridge/src/test/resources/atlas-log4j.xml 262a710f7 > addons/hive-bridge/src/test/resources/atlas-logback.xml PRE-CREATION > addons/impala-bridge/pom.xml 915dcbb4b > addons/impala-bridge/src/main/resources/atlas-log4j.xml 97317a875 > addons/impala-bridge/src/test/resources/atlas-log4j.xml c661d36f8 > addons/impala-bridge/src/test/resources/atlas-logback.xml PRE-CREATION > addons/kafka-bridge/pom.xml 093db7229 > addons/kafka-bridge/src/main/resources/atlas-kafka-import-log4j.xml > 3fc2dcf9c > addons/kafka-bridge/src/main/resources/atlas-kafka-import-logback.xml > PRE-CREATION > addons/kafka-bridge/src/test/resources/atlas-log4j.xml 0b9b36e36 > addons/kafka-bridge/src/test/resources/atlas-logback.xml PRE-CREATION > addons/sqoop-bridge/pom.xml 4b6eac98f > addons/sqoop-bridge/src/test/resources/atlas-log4j.xml 262a710f7 > addons/sqoop-bridge/src/test/resources/atlas-logback.xml PRE-CREATION > addons/storm-bridge/pom.xml 00dfe33a1 > addons/storm-bridge/src/test/resources/atlas-log4j.xml 262a710f7 > addons/storm-bridge/src/test/resources/atlas-logback.xml PRE-CREATION > common/src/test/resources/atlas-log4j.xml 4f1551857 > common/src/test/resources/atlas-logback.xml PRE-CREATION > common/src/test/resources/log4j.properties d62cf8045 > distro/src/bin/atlas_client_cmdline.py 1691526e2 > distro/src/bin/atlas_start.py f7d51c090 > distro/src/conf/atlas-log4j.xml 90e1301a1 > distro/src/conf/atlas-logback.xml PRE-CREATION > distro/src/conf/zookeeper/log4j.properties 5f5de7892 > distro/src/conf/zookeeper/logback.xml PRE-CREATION > distro/src/main/assemblies/atlas-server-package.xml 6086d0746 > distro/src/main/assemblies/classification-updater.xml 03a9b6861 > distro/src/main/assemblies/migration-exporter.xml 4907a683c > distro/src/main/assemblies/notification-analyzer.xml 63d9f2490 > distro/src/main/assemblies/standalone-package.xml 888d3edf4 > distro/src/test/python/scripts/TestMetadata.py bebf35e5b > intg/src/main/resources/atlas-log4j.xml 13a7f9684 > intg/src/main/resources/atlas-logback.xml PRE-CREATION > notification/pom.xml 4e5d9a835 > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 19479d0ad > notification/src/main/java/org/apache/atlas/hook/FailedMessagesLogger.java > 2118ba605 > > notification/src/main/java/org/apache/atlas/notification/LogConfigUtils.java > f2e50c5d2 > pom.xml 8dda9d387 > test-tools/pom.xml 45cd881e9 > test-tools/src/main/resources/logback.xml PRE-CREATION > tools/atlas-index-repair/src/main/resources/atlas-log4j.xml 9346a3692 > tools/atlas-index-repair/src/main/resources/atlas-logback.xml PRE-CREATION > tools/atlas-index-repair/src/main/resources/repair_index.py d72c2c907 > tools/atlas-migration-exporter/atlas-log4j.xml ae0d27ded > tools/atlas-migration-exporter/atlas-logback.xml PRE-CREATION > tools/atlas-migration-exporter/atlas_migration_export.py f57f39d05 > tools/classification-updater/src/main/resources/atlas-log4j.xml 9658edf4e > tools/classification-updater/src/main/resources/atlas-logback.xml > PRE-CREATION > tools/notification-analyzer/pom.xml 2f772a76f > tools/notification-analyzer/src/main/resources/atlas-log4j.xml 0f9182f36 > tools/notification-analyzer/src/main/resources/atlas-logback.xml > PRE-CREATION > webapp/pom.xml 8ab25cc6b > > > Diff: https://reviews.apache.org/r/75270/diff/4/ > > > Testing > ------- > > - successfully built and brought up Atlas in docker containers > - ran quick_start.py > - successfully ran: import-hive.sh, import-hbase.sh, import-kafka.sh > - precommit tests run: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1708/ > > > Thanks, > > Madhan Neethiraj > >
