-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75336/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and
Sheetal Shah.
Bugs: ATLAS-4956
https://issues.apache.org/jira/browse/ATLAS-4956
Repository: atlas
Description
-------
Problem:
--------
When tag is created with "description" as name it was throwing
ClassCastException.
Solution:
--------
The above issue was seen in all typeDef creation so, we have modified default
property keys format by adding "__" before some typeDef attributes.
For eg:
Earlier the name of the typeDef was stored as:
"__type.name"
Now, the name of the typeDef was stored as:
"__type.__name"
These changes was done as when any typeDef vertex was created it was also
adding another propertyKey with the format "__type.typeDef_name" having "List"
as datatype and was storing attributes name of the respected typeDef. So, while
creating vertex of description tag, when new property key i.e
"__type.typeDef_name" gets added to the vertex it override its value to the
existing default property "__type.description" and while fetching the
atrributes names of the typeDef it was throwing this exception.
Note: All typeDefs vertex has "__type" prefix for some default property keys.
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java 2134133f5
repository/src/main/java/org/apache/atlas/repository/patches/AddMandatoryAttributesPatch.java
310251698
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
c41b75dc3
repository/src/main/java/org/apache/atlas/repository/patches/ClassificationTextPatch.java
a3415c003
repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java
e5dcb2ef6
repository/src/main/java/org/apache/atlas/repository/patches/ProcessImpalaNamePatch.java
7eb918481
repository/src/main/java/org/apache/atlas/repository/patches/ProcessNamePatch.java
9889d4680
repository/src/main/java/org/apache/atlas/repository/patches/SuperTypesUpdatePatch.java
a77ca70cb
repository/src/main/java/org/apache/atlas/repository/patches/TypeDefAttributePatch.java
PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java
c30bd2596
Diff: https://reviews.apache.org/r/75336/diff/1/
Testing
-------
Manual testing done.
Thanks,
Priyanshi Shah
