----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75341/#review227183 -----------------------------------------------------------
common/src/main/java/org/apache/atlas/groovy/ArithmeticExpression.java Line 60 (original), 65 (patched) <https://reviews.apache.org/r/75341/#comment315430> Indentation inconsistency at Line # 65, 69 common/src/main/java/org/apache/atlas/groovy/ComparisonExpression.java Line 65 (original), 69 (patched) <https://reviews.apache.org/r/75341/#comment315429> Indentation inconsistency Line # 69 & 73 common/src/main/java/org/apache/atlas/groovy/LiteralExpression.java Line 115 (original), 98 (patched) <https://reviews.apache.org/r/75341/#comment315431> Indentation inconsistency - Radhika Kundam On Jan. 14, 2025, 3:59 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75341/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2025, 3:59 p.m.) > > > Review request for atlas, Ashutosh Mestry, chaitali, Disha Talreja, Jayendra > Parab, keval bhatt, Mandar Ambawane, Nixon Rodrigues, Chandrakanth Peravelli, > Pinal Shah, Radhika Kundam, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-4957 > https://issues.apache.org/jira/browse/ATLAS-4957 > > > Repository: atlas > > > Description > ------- > > Updated atlas-common module sources to comply with checkstyle requirements > > > Diffs > ----- > > common/pom.xml 0e80cfe00 > common/src/main/java/org/apache/atlas/AtlasConstants.java ce0dbd0b4 > > common/src/main/java/org/apache/atlas/annotation/ConditionalOnAtlasProperty.java > 427e3a8f8 > common/src/main/java/org/apache/atlas/annotation/Timed.java b892a16c7 > > common/src/main/java/org/apache/atlas/groovy/AbstractFunctionExpression.java > 2e2307c0d > common/src/main/java/org/apache/atlas/groovy/AbstractGroovyExpression.java > e4a778109 > common/src/main/java/org/apache/atlas/groovy/ArithmeticExpression.java > fff104b7c > common/src/main/java/org/apache/atlas/groovy/BinaryExpression.java > 852845ea3 > common/src/main/java/org/apache/atlas/groovy/CastExpression.java 808f327f9 > common/src/main/java/org/apache/atlas/groovy/ClosureExpression.java > a5ca0b6fd > common/src/main/java/org/apache/atlas/groovy/ComparisonExpression.java > b64533f46 > > common/src/main/java/org/apache/atlas/groovy/ComparisonOperatorExpression.java > c9e363e11 > common/src/main/java/org/apache/atlas/groovy/FieldExpression.java 6a182ad6d > common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java > ad09e3f96 > common/src/main/java/org/apache/atlas/groovy/GroovyExpression.java > 839914729 > common/src/main/java/org/apache/atlas/groovy/GroovyGenerationContext.java > a4e485b70 > common/src/main/java/org/apache/atlas/groovy/IdentifierExpression.java > 4c0694a40 > common/src/main/java/org/apache/atlas/groovy/LabeledExpression.java > a99341024 > common/src/main/java/org/apache/atlas/groovy/ListExpression.java 796942601 > common/src/main/java/org/apache/atlas/groovy/LiteralExpression.java > 14074994f > common/src/main/java/org/apache/atlas/groovy/LogicalExpression.java > 68e6847a0 > common/src/main/java/org/apache/atlas/groovy/RangeExpression.java 977adb6b0 > common/src/main/java/org/apache/atlas/groovy/StatementListExpression.java > f9c88ec11 > common/src/main/java/org/apache/atlas/groovy/TernaryOperatorExpression.java > 8835dd2f3 > common/src/main/java/org/apache/atlas/groovy/TraversalStepType.java > fde88147c > common/src/main/java/org/apache/atlas/groovy/TypeCoersionExpression.java > 956dafa0d > > common/src/main/java/org/apache/atlas/groovy/VariableAssignmentExpression.java > 1aa74435d > common/src/main/java/org/apache/atlas/ha/HAConfiguration.java 91fd4e107 > common/src/main/java/org/apache/atlas/pc/StatusReporter.java 507e842b8 > common/src/main/java/org/apache/atlas/pc/WorkItemBuilder.java 6dcb29d6a > common/src/main/java/org/apache/atlas/pc/WorkItemConsumer.java dd76697a5 > common/src/main/java/org/apache/atlas/pc/WorkItemManager.java 351421e8e > common/src/main/java/org/apache/atlas/repository/Constants.java 2134133f5 > common/src/main/java/org/apache/atlas/service/Service.java c87a240fa > common/src/main/java/org/apache/atlas/service/Services.java 2d548467f > common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java > ecdf8c5d1 > common/src/main/java/org/apache/atlas/utils/AtlasPerfMetrics.java a65dc8606 > common/src/main/java/org/apache/atlas/utils/AtlasPerfTracer.java a2baa65b0 > common/src/main/java/org/apache/atlas/utils/HdfsNameServiceResolver.java > 4b9d0bef2 > common/src/main/java/org/apache/atlas/utils/KafkaUtils.java 672caa8e6 > common/src/main/java/org/apache/atlas/utils/LruCache.java dcaffef6d > common/src/main/java/org/apache/atlas/utils/OnAtlasPropertyCondition.java > 7259036be > common/src/main/java/org/apache/atlas/utils/ParamChecker.java c8d7464dc > common/src/main/java/org/apache/atlas/utils/PathExtractorContext.java > ce688e4e4 > common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java e7c4b9448 > common/src/main/java/org/apache/atlas/utils/SHA256Utils.java 0b570685a > common/src/test/java/org/apache/atlas/ha/HAConfigurationTest.java b1188f914 > common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java > c232a7ac8 > > common/src/test/java/org/apache/atlas/utils/HdfsNameServiceResolverTest.java > 30bc2e1a3 > common/src/test/java/org/apache/atlas/utils/KafkaUtilsTest.java 9b4f093e7 > common/src/test/java/org/apache/atlas/utils/LruCacheTest.java 24d62f5b4 > repository/src/test/java/org/apache/atlas/pc/StatusReporterTest.java > a0c399b44 > repository/src/test/java/org/apache/atlas/pc/WorkItemManagerTest.java > e72bdd027 > > repository/src/test/java/org/apache/atlas/pc/WorkItemManagerWithResultsTest.java > a12b59728 > > > Diff: https://reviews.apache.org/r/75341/diff/1/ > > > Testing > ------- > > - verified that build of atlas-common module completes successfully without > any checkstyle violations > > > Thanks, > > Madhan Neethiraj > >
