-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75014/
-----------------------------------------------------------
(Updated Feb. 10, 2025, 7:04 a.m.)
Review request for atlas, Mandar Ambawane and Pinal Shah.
Bugs: ATLAS-4867
https://issues.apache.org/jira/browse/ATLAS-4867
Repository: atlas
Description
-------
Metrics API : http://<>/api/atlas/admin/metrics
1. There is some information in the Metrics API response, which is not been
used like Count of the typeAndSubTypes, Active, deleted, Shell
Approach:
Identify time taken by the above counts
Take reading of metric api
Take reading of metric api without the above counts
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/services/MetricsService.java
85b1634bf
repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java
49b3ac6bf
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
5ea7c0aee
Diff: https://reviews.apache.org/r/75014/diff/4/
Changes: https://reviews.apache.org/r/75014/diff/3-4/
Testing
-------
With typeAndSubTypes data it took 4578ms for Active (22,994,801), Deleted
(139,398) and Shell (166,280) for Metric API
First Time -> Without typeAndSubTypes data, it took 2927ms for Metric API
Then two subsequent request took around 2389ms and 2234ms for metric API.
+--------------------------------------------------------+--------------------------+-------------------------------+
| | Time taken first
request | Time taken subsequent request |
| typeAndSubTypes, Active, deleted, Shell in Metric API |
| |
+========================================================+==========================+===============================+
| With typeAndSubTypes | 4578ms
| 4152ms and 3914ms |
+--------------------------------------------------------+--------------------------+-------------------------------+
| Without typeAndSubTypes | 2927ms
| 2389ms and 2234ms |
+--------------------------------------------------------+--------------------------+-------------------------------+
PC build:-
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1715/
Thanks,
Paresh Devalia