[
https://issues.apache.org/jira/browse/ATLAS-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956248#comment-17956248
]
Aditya Gupta commented on ATLAS-5053:
-------------------------------------
Can refer the doc. It includes findings, analysis, UI snippets wrt to Basic
Filter and Group Filter code changes of Basic and Classification Search:
https://docs.google.com/document/d/15gnp3XR7R7wxAOl5Wi3SXDutQrkIuyTFrdeC5CFsnrI/edit?usp=sharing
> Add recursive validation in Basic Search API to fix regression issue
> --------------------------------------------------------------------
>
> Key: ATLAS-5053
> URL: https://issues.apache.org/jira/browse/ATLAS-5053
> Project: Atlas
> Issue Type: Bug
> Components: atlas-core
> Reporter: Paresh Devalia
> Assignee: Aditya Gupta
> Priority: Major
>
> Regression issue identified in the /v2/search/basic API of Apache Atlas,
> where recursive validation logic was unintentionally omitted in the previous
> fix.
> Due to this missing recursive check, the API is returning incorrect results
> and bad request.
> Example:
> below is the json request:
> http://localhost:21000/api/atlas/v2/search/basic
> {
> "excludeDeletedEntities": true,
> "includeSubClassifications": true,
> "includeSubTypes": true,
> "includeClassificationAttributes": true,
> "entityFilters": {
> "condition": "AND",
> "criterion": [
> {
> "attributeName": "__classificationNames",
> "operator": "eq",
> "attributeValue": "GameCatA"
> },
> {
> "condition": "AND",
> "criterion": [
> {
> "attributeName": "year_held",
> "operator": "eq",
> "attributeValue": "2006"
> }
> ]
> }
> ]
> },
> "tagFilters": null,
> "attributes": [
> "__classificationNames",
> "__typeName",
> "year_held"
> ],
> "limit": 25,
> "offset": 0,
> "typeName": "tournament",
> "classification": null,
> "termName": null
> }
> As one can see, inside entity filter, we have criterion which in itself has
> condition and criterion i.e following nested pattern[recursively filtered],
> si in such case it gives:
> {
> "errorCode": "ATLAS-400-00-103",
> "errorMessage": "Invalid operator specified for attribute: null"
> }
> So we will handle this Complex filter validation[i.e. Add Filter Group
> Option] in this Jira. Earlier it was only able to handle basic filter[i.e.
> normal Add Filter Option]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
